fix(@ngtools/webpack): JIT mode CommonJS accessing inexistent default property - #22247
Merged
Conversation
alan-agius4
added
the
target: patch
…t` property With this change we fix an issue in JIT mode were we try to access an inexistent `default` property of styles modules when emitted in CJS. Also, we now emit templates modules without the default property when not targeting ES2015 or greater to normalize the how to `require` templates and styles. Closes #21588
dgp1130
approved these changes
Nov 29, 2021
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change we fix an issue in JIT mode were we try to access an inexistent
defaultproperty of styles modules when emitted in CJS.Also, we now emit templates modules without the default property when not targeting ES2015 or greater to normalize the how to
requiretemplates and styles.Closes #21588